netdev - Re: [PATCH net-next] cxgb4vf: fix memleak in mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181109.151923.1249437011739571573.davem@davemloft.net>
Date:   Fri, 09 Nov 2018 15:19:23 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     arjun@...lsio.com
Cc:     netdev@...r.kernel.org, nirranjan@...lsio.com,
        indranil@...lsio.com, dt@...lsio.com, ganeshgr@...lsio.com
Subject: Re: [PATCH net-next] cxgb4vf: fix memleak in mac_hlist
 initialization

From: Arjun Vynipadath <arjun@...lsio.com>
Date: Fri,  9 Nov 2018 14:52:01 +0530

> mac_hlist was initialized during adapter_up, which will be called
> every time a vf device is first brought up, or every time when device
> is brought up again after bringing all devices down. This means our
> state of previous list is lost, causing a memleak if entries are
> present in the list. To fix that, move list init to the condition
> that performs initial one time adapter setup.
> 
> Signed-off-by: Arjun Vynipadath <arjun@...lsio.com>
> Signed-off-by: Ganesh Goudar <ganeshgr@...lsio.com>

Applied.