netdev - Re: [PATCH net 1/1] bnx2x: Assign unique DMAE channel number for FW DMAE transactions.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181109.152202.1670898351591745529.davem@davemloft.net>
Date:   Fri, 09 Nov 2018 15:22:02 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     sudarsana.kalluru@...ium.com
Cc:     netdev@...r.kernel.org, Michal.Kalderon@...ium.com
Subject: Re: [PATCH net 1/1] bnx2x: Assign unique DMAE channel number for
 FW DMAE transactions.

From: Sudarsana Reddy Kalluru <sudarsana.kalluru@...ium.com>
Date: Fri, 9 Nov 2018 02:10:43 -0800

> +/* Following is the DMAE channel number allocation for the clients.
> + *   MFW: OCBB/OCSD implementations use DMAE channels 14/15 respectively.
> + *   Driver: 0-3 and 8-11 (for PF dmae operations)
> + *           4 and 12 (for stats requests)
> + */
> +#define BNX2X_FW_DMAE_C                 13 /* Channel for FW DMAE operations */
 ...
> +	start_params->dmae_cmd_id = BNX2X_FW_DMAE_C;

Why do you need this, it never changes, and:

> +	rdata->dmae_cmd_id	= start_params->dmae_cmd_id;

It always is the same value here in the one place it is used.

Just assign BNX2X_FW_DMAE_C directly to rdata->dmae_cmd_id please.