netdev - Re: [PATCH v2 net] inet: frags: better deal with smp races

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181108.184117.1189358377262405362.davem@davemloft.net>
Date:   Thu, 08 Nov 2018 18:41:17 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        soukjin.bae@...sung.com
Subject: Re: [PATCH v2 net] inet: frags: better deal with smp races

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu,  8 Nov 2018 17:34:27 -0800

> Multiple cpus might attempt to insert a new fragment in rhashtable,
> if for example RPS is buggy, as reported by 배석진 in
> https://patchwork.ozlabs.org/patch/994601/
> 
> We use rhashtable_lookup_get_insert_key() instead of
> rhashtable_insert_fast() to let cpus losing the race
> free their own inet_frag_queue and use the one that
> was inserted by another cpu.
> 
> Fixes: 648700f76b03 ("inet: frags: use rhashtables for reassembly units")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: 배석진 <soukjin.bae@...sung.com>

Applied and queued up for -stable, thanks.