netdev - Re: [PATCH net-next] dpaa2-eth: Introduce TX congestion management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181108.192621.440627354669118853.davem@davemloft.net>
Date:   Thu, 08 Nov 2018 19:26:21 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     ruxandra.radulescu@....com
Cc:     netdev@...r.kernel.org, ioana.ciornei@....com
Subject: Re: [PATCH net-next] dpaa2-eth: Introduce TX congestion management

From: Ioana Ciocoi Radulescu <ruxandra.radulescu@....com>
Date: Thu, 8 Nov 2018 20:21:15 +0000

> Today I tried to further coalesce the confirmation frames such that I call
> netdev_tx_completed_queue() only at the end of the NAPI poll, once for each
> confirmation queue that was serviced during that NAPI.

That sounds like exactly what you should do given your design description.

> I need to do more testing, but so far it performs *almost* on par
> with the non-BQL driver version. But it does complicate the fastpath
> code and feels somewhat unnatural.

Well, this is exactly what should happen with BQL and as a result you will
get much better TCP queue utilization and avoidance of bufferbloat.