netdev - Re: [patch net] net: dsa: mv88e6xxx: Fix clearing of stats counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 11 Nov 2018 10:19:46 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     andrew@...n.ch
Cc:     netdev@...r.kernel.org
Subject: Re: [patch net] net: dsa: mv88e6xxx: Fix clearing of stats counters

From: Andrew Lunn <andrew@...n.ch>
Date: Sun, 11 Nov 2018 00:41:10 +0100

> The mv88e6161 would sometime fail to probe with a timeout waiting for
> the switch to complete an operation. This operation is supposed to
> clear the statistics counters. However, due to a read/modify/write,
> without the needed mask, the operation actually carried out was more
> random, with invalid parameters, resulting in the switch not
> responding. We need to preserve the histogram mode bits, so apply a
> mask to keep them.
> 
> Reported-by: Chris Healy <Chris.Healy@....aero>
> Fixes: 40cff8fca9e3 ("net: dsa: mv88e6xxx: Fix stats histogram mode")
> Signed-off-by: Andrew Lunn <andrew@...n.ch>

Oops.

Applied and queued up for -stable.