netdev - Re: [PATCH net-next v2] PCI: add USR vendor id and use it in r8169 and w6692 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 11 Nov 2018 10:23:47 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     bhelgaas@...gle.com, isdn@...ux-pingi.de, netdev@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH net-next v2] PCI: add USR vendor id and use it in r8169
 and w6692 driver

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 11 Nov 2018 11:50:08 +0100

> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 69f0abe1b..1fac231fe 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2359,6 +2359,10 @@
>  
>  #define PCI_VENDOR_ID_SYNOPSYS		0x16c3
>  
> +#define PCI_VENDOR_ID_USR		0x16ec
> +#define PCI_DEVICE_ID_USR_997902	0x0116
> +#define PCI_DEVICE_ID_USR_6692		0x3409
> +
>  #define PCI_VENDOR_ID_VITESSE		0x1725
>  #define PCI_DEVICE_ID_VITESSE_VSC7174	0x7174

Generally, as I understand the policy for linux/pci_ids.h, we only add
things used in multiple locations.

So PCI_VENDOR_ID_USR is OK, since it is used in both r8169 and w6692.

But the device IDs are not, since only w6692 uses them.