netdev - Re: [PATCH net-next v3] PCI: add USR vendor id and use it in r8169 and w6692 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181111.140019.2064956560683911866.davem@davemloft.net>
Date:   Sun, 11 Nov 2018 14:00:19 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     bhelgaas@...gle.com, isdn@...ux-pingi.de, netdev@...r.kernel.org,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH net-next v3] PCI: add USR vendor id and use it in r8169
 and w6692 driver

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Sun, 11 Nov 2018 20:31:21 +0100

> The PCI vendor id of U.S. Robotics isn't defined in pci_ids.h so far,
> only ISDN driver w6692 has a private definition. Move the definition
> to pci_ids.h and use it in the r8169 driver too.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>
> ---
> v2:
> - The original patch caused a build failure in w6692 driver because
>   it broke the private PCI device id definition.
> v3:
> - Don't move device id's to pci_ids.h because they are used in
>   one module only respectively.

Yep, that's better.

Applied, thanks!