netdev - Re: [PATCH net-next 01/17] net: sched: refactor mini_qdisc_pair

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181112.092809.744587974364715455.davem@davemloft.net>
Date:   Mon, 12 Nov 2018 09:28:09 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     vladbu@...lanox.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, ast@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH net-next 01/17] net: sched: refactor
 mini_qdisc_pair_swap() to use workqueue

From: Vlad Buslov <vladbu@...lanox.com>
Date: Mon, 12 Nov 2018 09:55:30 +0200

> +void mini_qdisc_pair_swap(struct mini_Qdisc_pair *miniqp,
> +			  struct tcf_proto *tp_head)
> +{
> +	xchg(&miniqp->tp_head, tp_head);

If you are not checking the return value of xchg(), then this is
simply a store with optionally a memory barrier of some sort
either before or after.