netdev - Re: [PATCH net-next 17/17] net: sched: unlock rules update API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181112.093014.891880255643252936.davem@davemloft.net>
Date:   Mon, 12 Nov 2018 09:30:14 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     vladbu@...lanox.com
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        jiri@...nulli.us, ast@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH net-next 17/17] net: sched: unlock rules update API

From: Vlad Buslov <vladbu@...lanox.com>
Date: Mon, 12 Nov 2018 09:55:46 +0200

> Register netlink protocol handlers for message types RTM_NEWTFILTER,
> RTM_DELTFILTER, RTM_GETTFILTER as unlocked. Set rtnl_held variable that
> tracks rtnl mutex state to be false by default.

This whole conditional locking mechanism is really not clean and makes
this code so much harder to understand and audit.

Please improve the code so that this kind of construct is not needed.

Thank you.