[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20181112154035.56de5e23@vmware.local.home>
Date: Mon, 12 Nov 2018 15:40:35 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Cc: Geneviève Bastien <gbastien@...satic.net>,
"David S. Miller" <davem@...emloft.net>,
netdev <netdev@...r.kernel.org>, Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH v2] net: Add trace events for all receive exit points
On Mon, 12 Nov 2018 15:20:55 -0500 (EST)
Mathieu Desnoyers <mathieu.desnoyers@...icios.com> wrote:
>
> Hrm, looking at this again, I notice that there is a single DEFINE_EVENT
> using net_dev_template_simple.
>
> We could simply turn netif_receive_skb_list_exit into a TRACE_EVENT(),
> remove the net_dev_template_simple, and rename the net_dev_template_return
> to net_dev_template ?
This too is only cosmetic and doesn't affect the code at all, because a
TRACE_EVENT() is really just:
#define TRACE_EVENT(name, proto, args, tstruct, assign, print) \
DECLARE_EVENT_CLASS(name, \
PARAMS(proto), \
PARAMS(args), \
PARAMS(tstruct), \
PARAMS(assign), \
PARAMS(print)); \
DEFINE_EVENT(name, name, PARAMS(proto), PARAMS(args));
-- Steve
>
> It's pretty clear from the prototype that it expects a "ret" argument,
> so I don't see the need to also state it in the template name.
>
>
Powered by blists - more mailing lists