netdev - Re: [PATCH] geneve: Add missing braces in addr6 initializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <94a6e57e1d546a5c406e31c1ed8b20531f415feb.camel@perches.com>
Date:   Mon, 12 Nov 2018 14:36:11 -0800
From:   Joe Perches <joe@...ches.com>
To:     Nathan Chancellor <natechancellor@...il.com>,
        "David S. Miller" <davem@...emloft.net>
Cc:     Stefano Brivio <sbrivio@...hat.com>,
        Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] geneve: Add missing braces in addr6 initializer

On Mon, 2018-11-12 at 15:12 -0700, Nathan Chancellor wrote:
> Clang warns:
> 
> drivers/net/geneve.c:428:29: error: suggest braces around initialization
> of subobject [-Werror,-Wmissing-braces]
>                 struct in6_addr addr6 = { 0 };
>                                           ^
>                                           {}

Perhaps just remove the 0.

> diff --git a/drivers/net/geneve.c b/drivers/net/geneve.c
[]
> @@ -425,7 +425,7 @@ static int geneve_udp_encap_err_lookup(struct sock *sk, struct sk_buff *skb)
>  #if IS_ENABLED(CONFIG_IPV6)
>  	if (geneve_get_sk_family(gs) == AF_INET6) {
>  		struct ipv6hdr *ip6h = ipv6_hdr(skb);
> -		struct in6_addr addr6 = { 0 };
> +		struct in6_addr addr6 = { { 0 } };
>  
>  		if (!gs->collect_md) {
>  			vni = geneve_hdr(skb)->vni;