netdev - Re: [PATCH tip/core/rcu 2/7] sfc: Replace spin_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d5a895b9-6d0b-1d51-dc97-96864c5335af@solarflare.com>
Date:   Mon, 12 Nov 2018 13:02:32 +0000
From:   Edward Cree <ecree@...arflare.com>
To:     "Paul E. McKenney" <paulmck@...ux.ibm.com>,
        <linux-kernel@...r.kernel.org>
CC:     <mingo@...nel.org>, <jiangshanlai@...il.com>,
        <dipankar@...ibm.com>, <akpm@...ux-foundation.org>,
        <mathieu.desnoyers@...icios.com>, <josh@...htriplett.org>,
        <tglx@...utronix.de>, <peterz@...radead.org>,
        <rostedt@...dmis.org>, <dhowells@...hat.com>,
        <edumazet@...gle.com>, <fweisbec@...il.com>, <oleg@...hat.com>,
        <joel@...lfernandes.org>, Lance Roy <ldr709@...il.com>,
        Solarflare linux maintainers <linux-net-drivers@...arflare.com>,
        Bert Kenward <bkenward@...arflare.com>,
        "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH tip/core/rcu 2/7] sfc: Replace spin_is_locked() with
 lockdep

On 11/11/18 20:04, Paul E. McKenney wrote:
> From: Lance Roy <ldr709@...il.com>
>
> lockdep_assert_held() is better suited to checking locking requirements,
> since it only checks if the current thread holds the lock regardless of
> whether someone else does. This is also a step towards possibly removing
> spin_is_locked().
>
> Signed-off-by: Lance Roy <ldr709@...il.com>
> Cc: Solarflare linux maintainers <linux-net-drivers@...arflare.com>
> Cc: Edward Cree <ecree@...arflare.com>
> Cc: Bert Kenward <bkenward@...arflare.com>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: <netdev@...r.kernel.org>
> Signed-off-by: Paul E. McKenney <paulmck@...ux.ibm.com>
> ---
Acked-by: Edward Cree <ecree@...arflare.com>
>  drivers/net/ethernet/sfc/efx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/sfc/efx.c b/drivers/net/ethernet/sfc/efx.c
> index 98fe7e762e17..3643015a55cf 100644
> --- a/drivers/net/ethernet/sfc/efx.c
> +++ b/drivers/net/ethernet/sfc/efx.c
> @@ -3167,7 +3167,7 @@ struct hlist_head *efx_rps_hash_bucket(struct efx_nic *efx,
>  {
>  	u32 hash = efx_filter_spec_hash(spec);
>  
> -	WARN_ON(!spin_is_locked(&efx->rps_hash_lock));
> +	lockdep_assert_held(&efx->rps_hash_lock);
>  	if (!efx->rps_hash_table)
>  		return NULL;
>  	return &efx->rps_hash_table[hash % EFX_ARFS_HASH_TABLE_SIZE];