netdev - Re: [PATCH net] l2tp: fix a sock refcnt leak in l2tp_tunnel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 13 Nov 2018 15:51:17 +0100
From:   Guillaume Nault <g.nault@...halink.fr>
To:     Xin Long <lucien.xin@...il.com>
Cc:     network dev <netdev@...r.kernel.org>, davem@...emloft.net
Subject: Re: [PATCH net] l2tp: fix a sock refcnt leak in l2tp_tunnel_register

On Tue, Nov 13, 2018 at 01:08:25AM +0800, Xin Long wrote:
> This issue happens when trying to add an existent tunnel. It
> doesn't call sock_put() before returning -EEXIST to release
> the sock refcnt that was held by calling sock_hold() before
> the existence check.
> 
> This patch is to fix it by holding the sock after doing the
> existence check.
> 
Nice fix. Thanks Xin!

Reviewed-by: Guillaume Nault <g.nault@...halink.fr>