netdev - Re: [PATCH net-next v2] geneve: Use empty braces for addr6 initializer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181113100228.6843ac40@redhat.com>
Date:   Tue, 13 Nov 2018 10:02:28 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     Nathan Chancellor <natechancellor@...il.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Sabrina Dubroca <sd@...asysnail.net>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>
Subject: Re: [PATCH net-next v2] geneve: Use empty braces for addr6
 initializer

On Mon, 12 Nov 2018 23:11:47 -0700
Nathan Chancellor <natechancellor@...il.com> wrote:

> Clang warns:
> 
> drivers/net/geneve.c:428:29: error: suggest braces around initialization
> of subobject [-Werror,-Wmissing-braces]
>                 struct in6_addr addr6 = { 0 };
>                                           ^
>                                           {}
> 
> Most initializations of structs in the kernel seem to use this format.
> 
> Fixes: a07966447f39 ("geneve: ICMP error lookup handler")
> Suggested-by: Joe Perches <joe@...ches.com>
> Signed-off-by: Nathan Chancellor <natechancellor@...il.com>

Also,

Reviewed-by: Stefano Brivio <sbrivio@...hat.com>

-- 
Stefano