netdev - Re: [PATCH net-next 02/17] net: sched: protect block state with spinlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181113110712.4462807a@redhat.com>
Date:   Tue, 13 Nov 2018 11:07:12 +0100
From:   Stefano Brivio <sbrivio@...hat.com>
To:     vladbu@...lanox.com
Cc:     David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
        jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
        ast@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH net-next 02/17] net: sched: protect block state with
 spinlock

Vlad,

On Mon, 12 Nov 2018 09:28:59 -0800 (PST)
David Miller <davem@...emloft.net> wrote:

> From: Vlad Buslov <vladbu@...lanox.com>
> Date: Mon, 12 Nov 2018 09:55:31 +0200
> 
> > +#define ASSERT_BLOCK_LOCKED(block)					\
> > +	WARN_ONCE(!spin_is_locked(&(block)->lock),		\
> > +		  "BLOCK: assertion failed at %s (%d)\n", __FILE__,  __LINE__)  
> 
> spin_is_locked() is not usable for assertions.

See also b86077207d0c ("igbvf: Replace spin_is_locked() with lockdep").

-- 
Stefano