netdev - Re: [PATCH v2 net-next 18/21] net: usb: aqc111: Implement get/set_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c85686b-8465-0c59-b145-acd3a7d2d419@aquantia.com>
Date:   Wed, 14 Nov 2018 07:46:50 +0000
From:   Igor Russkikh <Igor.Russkikh@...antia.com>
To:     Andrew Lunn <andrew@...n.ch>
CC:     "David S . Miller" <davem@...emloft.net>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Dmitry Bezrukov <Dmitry.Bezrukov@...antia.com>
Subject: Re: [PATCH v2 net-next 18/21] net: usb: aqc111: Implement
 get/set_link_ksettings callbacks


>> +	if (usb_speed == USB_SPEED_SUPER) {
>> +		ethtool_link_ksettings_add_link_mode(elk, supported,
>> +						     2500baseT_Full);
>> +		ethtool_link_ksettings_add_link_mode(elk, supported,
>> +						     5000baseT_Full);
>> +	}
> 
> Hi Igor
> 
> We discussed this with the first version of the patches. I think you
> should add a comment explaining why 2.5G and 5G is disabled unless
> Super speed is available.

Right, I've explained that to you but forgot to add a comment here.

>> +	if (aqc111_data->autoneg)
>> +		bitmap_copy(elk->link_modes.advertising,
>> +			    elk->link_modes.supported,
>> +			    __ETHTOOL_LINK_MODE_MASK_NBITS);
> 
> linkmode_copy(). It is quite new, so you probably don't know about it.

Ok,

Regards,
  Igor