netdev - Re: Ethernet on my CycloneV broke since 4.9.124

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <09777dc4-6769-795e-2256-a55a00f0ac01@kernel.org>
Date:   Thu, 15 Nov 2018 10:21:54 -0600
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     Clément Péron <peron.clem@...il.com>
Cc:     netdev@...r.kernel.org
Subject: Re: Ethernet on my CycloneV broke since 4.9.124



On 11/15/18 9:50 AM, Clément Péron wrote:
> Hi Dinh,
> 
> Did you upstream the patch on linux-stable ?
> 

Not yet...

Dinh
> On Fri, 2 Nov 2018 at 11:02, Clément Péron <peron.clem@...il.com> wrote:
>>
>> Hi Dinh,
>>
>> On Wed, 31 Oct 2018 at 23:02, Dinh Nguyen <dinguyen@...nel.org> wrote:
>>>
>>> Hi Clement,
>>>
>>> On 10/31/2018 10:36 AM, Clément Péron wrote:
>>>> Hi Dinh,
>>>>
>>>> On Wed, 31 Oct 2018 at 15:42, Dinh Nguyen <dinguyen@...nel.org> wrote:
>>>>>
>>>>> Hi Clement,
>>>>>
>>>>> On 10/31/2018 08:01 AM, Clément Péron wrote:
>>>>>> Hi,
>>>>>>
>>>>>> The patch "net: stmmac: socfpga: add additional ocp reset line for
>>>>>> Stratix10" introduce in 4.9.124 broke the ethernet on my CycloneV
>>>>>> board.
>>>>>>
>>>>>> When I boot i have this issue :
>>>>>>
>>>>>> socfpga-dwmac ff702000.ethernet: error getting reset control of ocp -2
>>>>>> socfpga-dwmac: probe of ff702000.ethernet failed with error -2
>>>>>>
>>>>>> Reverting the commit : 6f37f7b62baa6a71d7f3f298acb64de51275e724 fix the issue.
>>>>>>
>>>>>
>>>>> Are you sure? I just booted v4.9.124 and did not see any errors. The
>>>>> error should not appear because the commit is using
>>>>> devm_reset_control_get_optional().
>>>>
>>>> I'm booting on 4.9.130 actually, Agree with you that
>>>> devm_reset_control_get_optional should not failed but checking other
>>>> usage of this helper
>>>> https://elixir.bootlin.com/linux/v4.9.135/source/drivers/i2c/busses/i2c-mv64xxx.c#L824
>>>> https://elixir.bootlin.com/linux/v4.9.135/source/drivers/crypto/sunxi-ss/sun4i-ss-core.c#L259
>>>> Show that they don't check for errors except for PROBE_DEFER
>>>>
>>>
>>> I made a mistake, I was booting linux-next. I am seeing the error with
>>> v4.9.124. It's due to this commit not getting backported:
>>>
>>> "bb475230b8e59a reset: make optional functions really optional"
>>>
>>> I have backported the patch and is available here if you like to take a
>>> look:
>>
>> Thanks, works fine on my board too.
>> Regards,
>> Clement
>>
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/dinguyen/linux.git/log/?h=v4.9.124_optional_reset
>>>
>>> Dinh