netdev - Re: [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp and timestamping

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181116021418.dhbw5cu4y56cfjls@localhost>
Date:   Thu, 15 Nov 2018 18:14:18 -0800
From:   Richard Cochran <richardcochran@...il.com>
To:     Dalon Westergreen <dwesterg@...il.com>
Cc:     netdev@...r.kernel.org, dinguyen@...nel.org,
        thor.thayer@...ux.intel.com
Subject: Re: [PATCH net-next 6/8] net: eth: altera: tse: add support for ptp
 and timestamping

On Thu, Nov 15, 2018 at 06:55:29AM -0800, Dalon Westergreen wrote:
> Sure, I would like to keep the debugfs entries for disabling freq correction,and
> reading the current scaled_ppm value.  I intend to use these to tune anexternal
> vcxo.  If there is a better way to do this, please let me know.

Yes, there is.  The external VCXO should be a proper PHC.  Then, with
a minor change to the linuxptp stack (already in the pipe), you can
just use that.

You should not disable frequency correction in the driver.  Leave that
decision to the user space PTP stack.

> I would prefer to keep altera just to be consistent with the altera_tse stuff,
> and i intend to reusethis code for a 10GbE driver, so perhaps altera_tod to
> reference the fpga ip name?

So the IP core is called "tod"?  Really?

Thanks,
Richard