netdev - Re: [PATCH 05/11] nvmet: Add install

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <af370da9-3d56-e1a8-27db-c0a8e9291417@mellanox.com>
Date:   Sun, 18 Nov 2018 00:36:05 +0200
From:   Max Gurtovoy <maxg@...lanox.com>
To:     Sagi Grimberg <sagi@...htbitslabs.com>,
        <linux-nvme@...ts.infradead.org>
CC:     <linux-block@...r.kernel.org>, <netdev@...r.kernel.org>,
        Keith Busch <keith.busch@...el.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 05/11] nvmet: Add install_queue callout


On 11/15/2018 7:16 PM, Sagi Grimberg wrote:
> nvmet-tcp will implement it to allocate queue commands which
> are only known at nvmf connect time (sq size).
>
> Signed-off-by: Sagi Grimberg <sagi@...htbitslabs.com>
> ---
>   drivers/nvme/target/fabrics-cmd.c | 9 +++++++++
>   drivers/nvme/target/nvmet.h       | 1 +
>   2 files changed, 10 insertions(+)
>
> diff --git a/drivers/nvme/target/fabrics-cmd.c b/drivers/nvme/target/fabrics-cmd.c
> index 1f05d8507e35..a84668e8939c 100644
> --- a/drivers/nvme/target/fabrics-cmd.c
> +++ b/drivers/nvme/target/fabrics-cmd.c
> @@ -117,6 +117,15 @@ static u16 nvmet_install_queue(struct nvmet_ctrl *ctrl, struct nvmet_req *req)
>   	nvmet_sq_setup(ctrl, req->sq, qid, sqsize + 1,
>   			!!(c->cattr & NVME_CONNECT_DISABLE_SQFLOW));

what is your code base ? does SQFLOW must for TCP ?


>   
> +	if (ctrl->ops->install_queue) {
> +		int ret = ctrl->ops->install_queue(req->sq);
> +		if (ret) {
> +			pr_err("failed to install queue %d cntlid %d ret %d\n",
> +				qid, ret, ctrl->cntlid);
> +			return NVME_SC_CONNECT_INVALID_PARAM | NVME_SC_DNR;

I'm not sure regarding the INVALID_PARAM rc.

maybe use NVME_SC_INTERNAL ?

otherwise,

look fine,

Reviewed-by: Max Gurtovoy <maxg@...lanox.com>