netdev - Re: [PATCH v1] tg3: optionally get mac address from devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181116.193725.1381952801953862286.davem@davemloft.net>
Date:   Fri, 16 Nov 2018 19:37:25 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     thesven73@...il.com
Cc:     svendev@...x.com, siva.kallam@...adcom.com, prashant@...adcom.com,
        mchan@...adcom.com, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH v1] tg3: optionally get mac address from devicetree

From: thesven73@...il.com
Date: Tue, 13 Nov 2018 11:15:08 -0500

> If the tg3 has a device node, and that node contains a valid
> mac address property, use that as the tg3's mac address.
> 
> This behaviour was previously only present on SPARC, using a
> conditional compile (#ifdef CONFIG_SPARC), presumably because
> at the time, devicetree nodes for pci devices only worked on
> SPARC. However, this has recently been made universal, see
> commit 98d9f30c820d ("pci/of: Match PCI devices to OF nodes dynamically")
> 
> Devicetree example:
> (see Documentation/devicetree/bindings/pci/pci.txt)
> 
> &pcie {
> 	host@0 {
> 		#address-cells = <3>;
> 		#size-cells = <2>;
> 		reg = <0 0 0 0 0>;
> 		bcm5778: bcm5778@0 {
> 			reg = <0 0 0 0 0>;
> 			mac-address = [CA 11 AB 1E 10 01];
> 		};
> 	};
> };
> 
> Signed-off-by: Sven Van Asbroeck <svendev@...x.com>

Please use eth_platform_get_mac_address() and you can delete all of the
SPARC specific code altogether.