lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 16 Nov 2018 20:32:00 -0800 (PST) From: David Miller <davem@...emloft.net> To: starnight@...cu.edu.tw Cc: afaerber@...e.de, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, marcel@...tmann.org, dollar.chen@...ec.com, ken.yu@...wireless.com, linux-wpan@...r.kernel.org, stefan@...enfreihafen.org Subject: Re: [PATCH V3 2/7] net: lorawan: Add LoRaWAN socket module From: Jian-Hong Pan <starnight@...cu.edu.tw> Date: Thu, 15 Nov 2018 00:01:23 +0800 > +#define lrw_get_mac_cb(skb) ((struct lrw_mac_cb *)skb->cb) Please make this a static inline function. If the identifier is all lowercase programmers expect it to be real code not a CPP macro. > +#define LORAWAN_MODULE_NAME "lorawan" > + > +#define LRW_DBG_STR(fmt) LORAWAN_MODULE_NAME": "fmt > +#define lrw_info(fmt, ...) (pr_info(LRW_DBG_STR(fmt), ##__VA_ARGS__)) > +#define lrw_dbg(fmt, ...) (pr_debug(LRW_DBG_STR(fmt), ##__VA_ARGS__)) Just define "pr_fmt()" appropriately and you don't need to play these kinds of games. Set pr_fmt() and call pr_info() and pr_debug() directly.
Powered by blists - more mailing lists