netdev - Re: [PATCH bpf] bpf: fix off-by-one error in adjust_subprog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH3MdRUmaqmFWFS4xUuB3kVYZntExw3xw_nHJ+p013ZJ+bhtng@mail.gmail.com>
Date:   Sat, 17 Nov 2018 00:44:13 +0000
From:   Y Song <ys114321@...il.com>
To:     Edward Cree <ecree@...arflare.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        netdev <netdev@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        syzkaller-bugs@...glegroups.com
Subject: Re: [PATCH bpf] bpf: fix off-by-one error in adjust_subprog_starts

On Fri, Nov 16, 2018 at 12:00 PM Edward Cree <ecree@...arflare.com> wrote:
>
> When patching in a new sequence for the first insn of a subprog, the start
>  of that subprog does not change (it's the first insn of the sequence), so
>  adjust_subprog_starts should check start <= off (rather than < off).
> Also added a test to test_verifier.c (it's essentially the syz reproducer).
>
> Fixes: cc8b0b92a169 ("bpf: introduce function calls (function boundaries)")
> Reported-by: syzbot+4fc427c7af994b0948be@...kaller.appspotmail.com
> Signed-off-by: Edward Cree <ecree@...arflare.com>

Acked-by: Yonghong Song <yhs@...com>