netdev - Re: [Patch net] net: invert the check of detecting hardware RX checksum fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181117.164056.1575638266550325370.davem@davemloft.net>
Date:   Sat, 17 Nov 2018 16:40:56 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     herbert@...dor.apana.org.au
Cc:     xiyou.wangcong@...il.com, netdev@...r.kernel.org,
        tom@...bertland.com, edumazet@...gle.com
Subject: Re: [Patch net] net: invert the check of detecting hardware RX
 checksum fault

From: Herbert Xu <herbert@...dor.apana.org.au>
Date: Fri, 16 Nov 2018 09:52:42 +0800

> netdev_rx_csum_fault is meant to warn about the situation where
> a packet with a valid checksum (i.e., sum == 0) was given to us
> by the hardware with a partial checksum that was invalid.

Thanks for reminding us how this code is supposed to work :-)

Definitely we need to better document this and it looks like Cong is
going to add a comment in order to do so.

As for dumping out a packet, we need to rate limit that more strongly
than the existing net_ratelimit() there.  But only dumping once per
bootup seems to extreme in the other direction.  If we get like 2
or 3 of these in an hour, dumping all of them would be reasonable
and useful.