netdev - Re: [PATCH v1] tg3: optionally use eth_platform_get_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181118.125827.533500141350535906.davem@davemloft.net>
Date:   Sun, 18 Nov 2018 12:58:27 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     thesven73@...il.com
Cc:     svendev@...x.com, siva.kallam@...adcom.com, prashant@...adcom.com,
        mchan@...adcom.com, andrew@...n.ch, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, arnd@...db.de
Subject: Re: [PATCH v1] tg3: optionally use eth_platform_get_mac_address()
 to get mac address

From: thesven73@...il.com
Date: Sat, 17 Nov 2018 10:56:18 -0500

> This function will try to determine the mac address via the devicetree,
> or via an architecture-specific method (e.g. a PROM on SPARC).
> 
> The SPARC-specific code in this driver (#ifdef SPARC) did exactly this,
> and is therefore removed.
> 
> Note that you can now specify the tg3 mac address via the devicetree,
> on any platform, not just SPARC:
> 
> Devicetree example:
> (see Documentation/devicetree/bindings/pci/pci.txt)
> 
> &pcie {
> 	host@0 {
> 		#address-cells = <3>;
> 		#size-cells = <2>;
> 		reg = <0 0 0 0 0>;
> 		bcm5778: bcm5778@0 {
> 			reg = <0 0 0 0 0>;
> 			mac-address = [CA 11 AB 1E 10 01];
> 		};
> 	};
> };
> 
> Signed-off-by: Sven Van Asbroeck <svendev@...x.com>

Applied to net-next, thanks.