netdev - Re: [PATCH net-next] tun: use netdev_alloc_frag() in tun_napi_alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181118.190130.629339774009619633.davem@davemloft.net>
Date:   Sun, 18 Nov 2018 19:01:30 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        peterpenkov96@...il.com, maheshb@...gle.com, willemb@...gle.com
Subject: Re: [PATCH net-next] tun: use netdev_alloc_frag() in
 tun_napi_alloc_frags()

From: Eric Dumazet <edumazet@...gle.com>
Date: Sun, 18 Nov 2018 07:37:33 -0800

> In order to cook skbs in the same way than Ethernet drivers,
> it is probably better to not use GFP_KERNEL, but rather
> use the GFP_ATOMIC and PFMEMALLOC mechanisms provided by
> netdev_alloc_frag().
> 
> This would allow to use tun driver even in memory stress
> situations, especially if swap is used over this tun channel.
> 
> Fixes: 90e33d459407 ("tun: enable napi_gro_frags() for TUN/TAP driver")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.