netdev - Re: [PATCH mlx5-next 11/12] {net,IB}/mlx5: Move Page fault EQ and ODP logic to RDMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <247d4d885b0c04c8c28e54156a7c43b96fe0de10.camel@mellanox.com>
Date:   Mon, 19 Nov 2018 18:43:24 +0000
From:   Saeed Mahameed <saeedm@...lanox.com>
To:     Jason Gunthorpe <jgg@...lanox.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Leon Romanovsky <leonro@...lanox.com>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH mlx5-next 11/12] {net,IB}/mlx5: Move Page fault EQ and ODP
 logic to RDMA

On Sat, 2018-11-17 at 20:13 +0000, Jason Gunthorpe wrote:
> On Fri, Nov 16, 2018 at 01:59:00PM -0800, Saeed Mahameed wrote:
> > Use the new generic EQ API to move all ODP RDMA data structures and
> > logic
> > form mlx5 core driver into mlx5_ib driver.
> > 
> > Signed-off-by: Saeed Mahameed <saeedm@...lanox.com>
> > Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
> > Reviewed-by: Tariq Toukan <tariqt@...lanox.com>

[...]

> >  
> > +struct mlx5_ib_pf_eq {
> > +	struct mlx5_ib_dev      *dev;
> > +	struct mlx5_eq          *core;
> > +	struct work_struct       work;
> > +	spinlock_t               lock; /* Pagefaults spinlock */
> > +	struct workqueue_struct  *wq;
> > +	mempool_t                *pool;
> > +};
> 
> I know this is being copied, but can we please not do this vertical
> alignment madness in RDMA? It is such a nightmare to maintain this..
> 

Ack will fix and submit v2.

> > +/* mempool_refill() was proposed but unfortunately wasn't accepted
> > + * http://lkml.iu.edu/hypermail/linux/kernel/1512.1/05073.html
> > + * Chip workaround.
> 
> 'cheap workaround'
> 

Will fix

> Jason