netdev - [PATCH iproute2-next 1/8] tc: gred: remove unclear comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181119230335.11771-2-jakub.kicinski@netronome.com>
Date:   Mon, 19 Nov 2018 15:03:28 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     dsahern@...il.com, stephen@...workplumber.org
Cc:     oss-drivers@...ronome.com, netdev@...r.kernel.org,
        Jakub Kicinski <jakub.kicinski@...ronome.com>
Subject: [PATCH iproute2-next 1/8] tc: gred: remove unclear comment

The comment about providing a proper message seems similar to
the comment in the kernel which says:

    /* hack -- fix at some point with proper message
       This is how we indicate to tc that there is no VQ
       at this DP */

it's unclear what that message would be, and whether it's needed.
Remove the confusing comment.

Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
Reviewed-by: Quentin Monnet <quentin.monnet@...ronome.com>
---
 tc/q_gred.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tc/q_gred.c b/tc/q_gred.c
index e63fac72a883..80a9ccbbd3cb 100644
--- a/tc/q_gred.c
+++ b/tc/q_gred.c
@@ -302,8 +302,6 @@ static int gred_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt)
 		return -1;
 	}
 
-/* Bad hack! should really return a proper message as shown above*/
-
 	fprintf(f, "vqs %u default %u %s",
 		sopt->DPs,
 		sopt->def_DP,
-- 
2.17.1