netdev - Re: [PATCH net-next,v2 08/12] flow_dissector: add wake-up-on-lan and queue to flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181119135955.GH2223@nanopsycho.orion>
Date:   Mon, 19 Nov 2018 14:59:55 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        thomas.lendacky@....com, f.fainelli@...il.com,
        ariel.elior@...ium.com, michael.chan@...adcom.com,
        santosh@...lsio.com, madalin.bucur@....com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jeffrey.t.kirsher@...el.com, tariqt@...lanox.com,
        saeedm@...lanox.com, jiri@...lanox.com, idosch@...lanox.com,
        jakub.kicinski@...ronome.com, peppe.cavallaro@...com,
        grygorii.strashko@...com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, alexandre.torgue@...com,
        joabreu@...opsys.com, linux-net-drivers@...arflare.com,
        ganeshgr@...lsio.com, ogerlitz@...lanox.com
Subject: Re: [PATCH net-next,v2 08/12] flow_dissector: add wake-up-on-lan and
 queue to flow_action

Mon, Nov 19, 2018 at 01:15:15AM CET, pablo@...filter.org wrote:
>These actions need to be added to support bcm sf2 features available
>through the ethtool_rx_flow interface.
>
>Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
>Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

For me it would be nicer to have this as 2 patches, one per action type.
But up to you.


>---
>v2: no changes.
>
> include/net/flow_dissector.h | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/include/net/flow_dissector.h b/include/net/flow_dissector.h
>index 925c208816f1..7a4683646d5a 100644
>--- a/include/net/flow_dissector.h
>+++ b/include/net/flow_dissector.h
>@@ -418,6 +418,8 @@ enum flow_action_key_id {
> 	FLOW_ACTION_KEY_ADD,
> 	FLOW_ACTION_KEY_CSUM,
> 	FLOW_ACTION_KEY_MARK,
>+	FLOW_ACTION_KEY_WAKE,
>+	FLOW_ACTION_KEY_QUEUE,
> };
> 
> /* This is mirroring enum pedit_header_type definition for easy mapping between
>@@ -452,6 +454,7 @@ struct flow_action_key {
> 		const struct ip_tunnel_info *tunnel;	/* FLOW_ACTION_KEY_TUNNEL_ENCAP */
> 		u32			csum_flags;	/* FLOW_ACTION_KEY_CSUM */
> 		u32			mark;		/* FLOW_ACTION_KEY_MARK */
>+		u32			queue_index;	/* FLOW_ACTION_KEY_QUEUE */
> 	};
> };
> 
>-- 
>2.11.0
>