netdev - Re: [PATCH v2] ipv4: make DSCP values works with ip rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181120141218.GA3474@bistromath.localdomain>
Date:   Tue, 20 Nov 2018 15:12:18 +0100
From:   Sabrina Dubroca <sd@...asysnail.net>
To:     Pavel Balaev <mail@...d.so>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2] ipv4: make DSCP values works with ip rules

Hi Pavel,

2018-11-20, 16:29:36 +0300, Pavel Balaev wrote:
> This patch adds ability to set DSCP values in ip rules.

You dropped the RFC reference that you had in v1.

> Values presented in /etc/iproute3/rt_dsfield and now can be used in rules.

iproute3?

> 
> Example:
> $ ip ru add from 10.88.0.2 tos AF23 lookup dscp.
> Result:
> ---

Be careful when you write commit messages. "git am" is going to cut
out everything that comes after the first ^---$ line it sees, so the
rest of those explanations, as well as your sign-off, will be dropped.

> 32762:	from 10.88.0.2 tos AF43 lookup dscp
> ---
> 
> Patch was tested with such configuration:
> 
> +-----------+
> | 10.88.0.2 | -> ping 172.16.0.1 -Q 0x58 ->
> |   host0   |
> +-----------+
> 
>    +-------------------------------------+
>    | router with patched kernel          |
>    |                                     |
> -> | from 10.88.0.2 tos AF43 lookup dscp |->
>    | table dscp:                         |
>    |   172.16.0.0/24 via 10.200.0.2      |
>    +-------------------------------------+
> 
> 	 +------------------+
> -> | eth0: 10.200.0.2 |
>    | eth1: 172.16.0.1 |
>    |      host1       |
>    +------------------+
> 
> Signed-off-by: Pavel Balaev <mail@...d.so>

-- 
Sabrina