netdev - Re: [PATCH net] tcp: Fix SOF_TIMESTAMPING_RX_HARDWARE to use the latest timestamp during TCP coalescing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4582a956-1a1a-f684-35b3-06a9f2020825@gmail.com>
Date:   Tue, 20 Nov 2018 09:50:22 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Stephen Mallon <stephen.mallon@...ney.edu.au>,
        Eric Dumazet <edumazet@...gle.com>
Cc:     "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: Re: [PATCH net] tcp: Fix SOF_TIMESTAMPING_RX_HARDWARE to use the
 latest timestamp during TCP coalescing



On 11/20/2018 12:15 AM, Stephen Mallon wrote:
> During tcp coalescing ensure that the skb hardware timestamp refers to the
> highest sequence number data.
> Previously only the software timestamp was updated during coalescing.
> 
> Signed-off-by: Stephen Mallon <stephen.mallon@...ney.edu.au>
> ---
>  net/ipv4/tcp_input.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/ipv4/tcp_input.c b/net/ipv4/tcp_input.c
> index 2868ef28ce52..e695584bb33f 100644
> --- a/net/ipv4/tcp_input.c
> +++ b/net/ipv4/tcp_input.c
> @@ -4363,6 +4363,7 @@ static bool tcp_try_coalesce(struct sock *sk,
>  	if (TCP_SKB_CB(from)->has_rxtstamp) {
>  		TCP_SKB_CB(to)->has_rxtstamp = true;
>  		to->tstamp = from->tstamp;
> +		skb_hwtstamps(to)->hwtstamp = skb_hwtstamps(from)->hwtstamp;
>  	}
>  
>  	return true;
> 


SGTM, thanks !

Signed-off-by: Eric Dumazet <edumazet@...gle.com>