netdev - Re: [PATCH net-next] net_sched: sch_fq: avoid calling ktime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181120.095847.465708123173576470.davem@davemloft.net>
Date:   Tue, 20 Nov 2018 09:58:47 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] net_sched: sch_fq: avoid calling
 ktime_get_ns() if not needed

From: Eric Dumazet <edumazet@...gle.com>
Date: Mon, 19 Nov 2018 17:30:19 -0800

> There are two cases were we can avoid calling ktime_get_ns() :
> 
> 1) Queue is empty.
> 2) Internal queue is not empty.
> 
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied.

But just to be clear, if the qdisc is empty we do not need to update
flow credits etc.?