netdev - Re: [PATCH net-next] tcp: drop dst in tcp_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181120.102610.679905109392985656.davem@davemloft.net>
Date:   Tue, 20 Nov 2018 10:26:10 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com
Subject: Re: [PATCH net-next] tcp: drop dst in tcp_add_backlog()

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue, 20 Nov 2018 10:21:22 -0800

> On Tue, Nov 20, 2018 at 10:16 AM David Miller <davem@...emloft.net> wrote:
>>
>> Well, I'm sure we "handle" it.  But I was more asking about the performance
>> tradeoff, which probably is on the side of your change but I wanted to
>> just be sure.
> 
> Ah sorry for misunderstanding.
> Yes, that should be fine, backlog is not generally used at the
> beginning of a flow.
> 
> I am working on adding coalescing support to tcp_add_backlog() to balance
> time spent in softirq and time spent from process context, hoping to reduce
> probability of having user threads trapped for a while in __release_sock()

Ok, meanwhile I applied the patch under discussion.

Thanks.