netdev - Re: [PATCH bpf-next v2] libbpf: make sure bpf headers are c++ include-able

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181120234919.oby7bvbq7cf2q5g6@ast-mbp.dhcp.thefacebook.com>
Date:   Tue, 20 Nov 2018 15:49:21 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Stanislav Fomichev <sdf@...gle.com>
Cc:     netdev@...r.kernel.org, ast@...nel.org, daniel@...earbox.net,
        ys114321@...il.com
Subject: Re: [PATCH bpf-next v2] libbpf: make sure bpf headers are c++
 include-able

On Tue, Nov 20, 2018 at 01:37:23PM -0800, Stanislav Fomichev wrote:
> Wrap headers in extern "C", to turn off C++ mangling.
> This simplifies including libbpf in c++ and linking against it.
> 
> v2 changes:
> * do the same for btf.h
> 
> Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
> ---
>  tools/lib/bpf/bpf.h    | 9 +++++++++
>  tools/lib/bpf/btf.h    | 8 ++++++++
>  tools/lib/bpf/libbpf.h | 9 +++++++++
>  3 files changed, 26 insertions(+)
> 
> diff --git a/tools/lib/bpf/bpf.h b/tools/lib/bpf/bpf.h
> index 26a51538213c..9ea3aec82d8a 100644
> --- a/tools/lib/bpf/bpf.h
> +++ b/tools/lib/bpf/bpf.h
> @@ -27,6 +27,10 @@
>  #include <stdbool.h>
>  #include <stddef.h>
>  
> +#ifdef __cplusplus
> +extern "C" {
> +#endif

Acked-by: Alexei Starovoitov <ast@...nel.org>

was wondering whether it's possible to make it testable.
HOSTCXX is available, but I don't see much of the kernel tree
using it...