netdev - Re: [PATCH net-next] net: hns3: add common validation in hclge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff326b5b-0d37-a270-7a5a-182d81142475@huawei.com>
Date:   Tue, 20 Nov 2018 09:50:11 +0800
From:   Yunsheng Lin <linyunsheng@...wei.com>
To:     Tan Xiaojun <tanxiaojun@...wei.com>, <yisen.zhuang@...wei.com>,
        <salil.mehta@...wei.com>, <davem@...emloft.net>,
        <lipeng321@...wei.com>, <shenjian15@...wei.com>,
        <tanhuazhong@...wei.com>, <liangfuyun1@...wei.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <nhorman@...hat.com>
Subject: Re: [PATCH net-next] net: hns3: add common validation in hclge_dcb

On 2018/11/19 21:02, Tan Xiaojun wrote:
> From: Yunsheng Lin <linyunsheng@...wei.com>
> 
> Before setting tm related configuration to hardware, driver
> needs to check the configuration provided by user is valid.
> Currently hclge_ieee_setets and hclge_setup_tc both implement
> their own checking, which has a lot in common.
> 
> This patch addes hclge_dcb_common_validate to do the common
> checking. The checking in hclge_tm_prio_tc_info_update
> and hclge_tm_schd_info_update is unnecessary now, so change
> the return type to void, which removes the need to do error
> handling when one of the checking fails.
> 
> Also, ets->prio_tc is indexed by user prio and ets->tc_tsa is
> indexed by tc num, so this patch changes them to use different
> index.

+cc Neil

> 
> Signed-off-by: Yunsheng Lin <linyunsheng@...wei.com>
> Signed-off-by: Tan Xiaojun <tanxiaojun@...wei.com>