netdev - Re: [PATCH bpf-next v2] bpf: libbpf: retry map creation without the name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181120001246.jphhsm5buqggi2tm@mini-arch.hsd1.ca.comcast.net>
Date:   Mon, 19 Nov 2018 16:12:46 -0800
From:   Stanislav Fomichev <sdf@...ichev.me>
To:     Daniel Borkmann <daniel@...earbox.net>
Cc:     Stanislav Fomichev <sdf@...gle.com>, netdev@...r.kernel.org,
        ast@...nel.org, vladum@...gle.com
Subject: Re: [PATCH bpf-next v2] bpf: libbpf: retry map creation without the
 name

On 11/20, Daniel Borkmann wrote:
> On 11/19/2018 11:49 PM, Stanislav Fomichev wrote:
> > Since commit 88cda1c9da02 ("bpf: libbpf: Provide basic API support
> > to specify BPF obj name"), libbpf unconditionally sets bpf_attr->name
> > for maps. Pre v4.14 kernels don't know about map names and return an
> > error about unexpected non-zero data. Retry sys_bpf without a map
> > name to cover older kernels.
> > 
> > v2 changes:
> > * check for errno == EINVAL as suggested by Daniel Borkmann
> > 
> > Signed-off-by: Stanislav Fomichev <sdf@...gle.com>
> 
> Applied to bpf-next, thanks!
Great, thanks! It looks like there might be the same problem with the
program's name. I'll probably follow up with another patch soon.