netdev - Re: 答复: [PATCH 1/4] net-next/hinic:replace multiply and division operators

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181119.190000.791259337031857840.davem@davemloft.net>
Date:   Mon, 19 Nov 2018 19:00:00 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     xuechaojing@...wei.com
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        wulike1@...wei.com, chiqijun@...wei.com, fy.wang@...wei.com,
        tony.qu@...wei.com, luoshaokai@...wei.com
Subject: Re: 答复: [PATCH 1/4] net-next/hinic:replace
 multiply and division operators

From: xuechaojing <xuechaojing@...wei.com>
Date: Tue, 20 Nov 2018 02:21:31 +0000

> This wqebb size is 32 in rx and in tx is 64, so the value is a power
> of two.

You know this.

I know this.

But developer in the future may not and try to use non-power-of-2.

Please add the necessary checks.  I will not ask another time.