netdev - Re: [PATCH v2 07/14] nvme-core: add work elements to struct nvme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20181121130432.GB1373@lst.de>
Date:   Wed, 21 Nov 2018 14:04:32 +0100
From:   Christoph Hellwig <hch@....de>
To:     Sagi Grimberg <sagi@...mberg.me>
Cc:     linux-nvme@...ts.infradead.org, linux-block@...r.kernel.org,
        netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Keith Busch <keith.busch@...el.com>,
        Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v2 07/14] nvme-core: add work elements to struct
 nvme_ctrl

On Mon, Nov 19, 2018 at 07:00:09PM -0800, Sagi Grimberg wrote:
> From: Sagi Grimberg <sagi@...htbitslabs.com>
> 
> connect_work and err_work will be reused by nvme-tcp so
> share those in nvme_ctrl for rdma and fc to share.

As said before when you sent this invididually:  I'd rather not move
struct members to the common struture until we actually start using
it there.  So for now please add it to the containing TCP-specific
structure, although I'm looking forward to actually see code around
it consolidated eventually.