netdev - RE: [PATCH net-next 3/8] net: hns3: Add "FD flow table" info query function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <F4CC6FACFEB3C54C9141D49AD221F7F93BFC86CE@FRAEML521-MBX.china.huawei.com>
Date:   Wed, 21 Nov 2018 16:25:54 +0000
From:   Salil Mehta <salil.mehta@...wei.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "Zhuangyuzeng (Yisen)" <yisen.zhuang@...wei.com>,
        "lipeng (Y)" <lipeng321@...wei.com>,
        "mehta.salil@...src.net" <mehta.salil@...src.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linuxarm <linuxarm@...wei.com>,
        Liuzhongzhu <liuzhongzhu@...wei.com>
Subject: RE: [PATCH net-next 3/8] net: hns3: Add "FD flow table" info query
 function

Hi Jacub,

> From: Jakub Kicinski [mailto:jakub.kicinski@...ronome.com]
> Sent: Monday, November 19, 2018 10:31 PM
> To: Salil Mehta <salil.mehta@...wei.com>
> Cc: davem@...emloft.net; Zhuangyuzeng (Yisen) <yisen.zhuang@...wei.com>;
> lipeng (Y) <lipeng321@...wei.com>; mehta.salil@...src.net;
> netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Linuxarm
> <linuxarm@...wei.com>; Liuzhongzhu <liuzhongzhu@...wei.com>
> Subject: Re: [PATCH net-next 3/8] net: hns3: Add "FD flow table" info
> query function
> 
> On Mon, 19 Nov 2018 21:18:40 +0000, Salil Mehta wrote:
> > diff --git
> a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h.rej
> b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h.rej
> > new file mode 100644
> > index 000000000000..be7d0dea06e7
> > --- /dev/null
> > +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.h.rej
> > @@ -0,0 +1,12 @@
> > +*************** int hclge_set_vlan_filter(struct hnae3_handle
> *handle, __be16 proto,
> > +*** 800,803 ****
> > +  void hclge_reset_vf_queue(struct hclge_vport *vport, u16 queue_id);
> > +  int hclge_cfg_flowctrl(struct hclge_dev *hdev);
> > +  int hclge_func_reset_cmd(struct hclge_dev *hdev, int func_id);
> > +  #endif
> > +--- 800,804 ----
> > +  void hclge_reset_vf_queue(struct hclge_vport *vport, u16 queue_id);
> > +  int hclge_cfg_flowctrl(struct hclge_dev *hdev);
> > +  int hclge_func_reset_cmd(struct hclge_dev *hdev, int func_id);
> > ++ int hclge_dbg_run_cmd(struct hnae3_handle *handle, char *cmd_buf);
> > +  #endif
> 
> You probably don't need this.

Goodness! I was on a transit while I floated this patch-set, somehow
missed my quick review. Sorry for this and thanks for catching!

Best regards
Salil