netdev - RE: [PATCH v1 net] lan743x: fix return value for lan743x_tx_napi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <90A7E81AE28BAE4CBDDB3B35F187D264407528EE@CHN-SV-EXMX02.mchp-main.com>
Date:   Wed, 21 Nov 2018 16:47:13 +0000
From:   <Bryan.Whitehead@...rochip.com>
To:     <Tristram.Ha@...rochip.com>
CC:     <davem@...emloft.net>, <netdev@...r.kernel.org>,
        <UNGLinuxDriver@...rochip.com>, <andrew@...n.ch>,
        <f.fainelli@...il.com>
Subject: RE: [PATCH v1 net] lan743x: fix return value for
 lan743x_tx_napi_poll

> I notice 2 problems in the driver:
> 
> 1. netif_napi_add is used instead of netif_tx_napi_add.
> 2. In all other drivers that use netif_tx_napi_add most do not call
> napi_complete_done.
> They all call napi_complete directly and return 0.
> 
> freescale/gianfar.c
> rocker/rocker_main.c
> ti/cpsw.c
> 
> virtio_net.c does use napi_complete_done but it also passes 0 as a
> parameter.
> 
Tristram,

Thanks for the tips. I will make a new version which uses
  netif_tx_napi_add, and napi_complete

Regards,
Bryan