netdev - Re: [PATCH iproute2] ipnetns: parse nsid as a signed integer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181121093742.47755677@xeon-e3>
Date:   Wed, 21 Nov 2018 09:37:42 -0800
From:   Stephen Hemminger <stephen@...workplumber.org>
To:     Nicolas Dichtel <nicolas.dichtel@...nd.com>
Cc:     netdev@...r.kernel.org, dsahern@...il.com, joe@...d.net.nz,
        daniel@...earbox.net
Subject: Re: [PATCH iproute2] ipnetns: parse nsid as a signed integer

On Wed, 21 Nov 2018 10:44:27 +0100
Nicolas Dichtel <nicolas.dichtel@...nd.com> wrote:

> Don't confuse the user, nsid is a signed integer, this kind of command
> should return an error: 'ip netns set foo 0xffffffff'.
> 
> Also, a valid value is a positive value. To let the kernel chooses a value,
> the keyword 'auto' must be used.
> 
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@...nd.com>

Thanks for catching this. Next time add a Fixes: tag if possible.

Applied.