netdev - Re: [PATCH v2 14/14] nvme-tcp: add NVMe over TCP host driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <09c340a0-0b7f-ff9b-f196-7ba48a0ee234@grimberg.me>
Date:   Wed, 21 Nov 2018 14:27:16 -0800
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Christoph Hellwig <hch@....de>
Cc:     linux-nvme@...ts.infradead.org, linux-block@...r.kernel.org,
        netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH v2 14/14] nvme-tcp: add NVMe over TCP host driver


>> +struct nvme_tcp_send_ctx {
>> +	struct bio		*curr_bio;
>> +	struct iov_iter		iter;
>> +	size_t			offset;
>> +	size_t			data_sent;
>> +	enum nvme_tcp_send_state state;
>> +};
>> +
>> +struct nvme_tcp_recv_ctx {
>> +	struct iov_iter		iter;
>> +	struct bio		*curr_bio;
>> +};
> 
> I don't understand these structures.  There should only be
> a bio to be send or receive, not both.  Why do we need two
> curr_bio pointers?

We don't really need both...

> To me it seems like both structures should just go away and
> move into nvme_tcp_request ala:
> 
> 
> 	struct bio		*curr_bio;
> 
> 	/* send state */
> 	struct iov_iter		send_iter;
> 	size_t			send_offset;
> 	enum nvme_tcp_send_state send_state;
> 	size_t			data_sent;
> 
> 	/* receive state */
> 	struct iov_iter		recv_iter;
> 

Sure, will move this.