netdev - Re: [PATCH v2 07/14] nvme-core: add work elements to struct nvme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7833b3a4-cce5-238a-eef3-70702c443931@grimberg.me>
Date:   Wed, 21 Nov 2018 14:28:59 -0800
From:   Sagi Grimberg <sagi@...mberg.me>
To:     Christoph Hellwig <hch@....de>
Cc:     linux-nvme@...ts.infradead.org, linux-block@...r.kernel.org,
        netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Keith Busch <keith.busch@...el.com>
Subject: Re: [PATCH v2 07/14] nvme-core: add work elements to struct nvme_ctrl


>> connect_work and err_work will be reused by nvme-tcp so
>> share those in nvme_ctrl for rdma and fc to share.
> 
> As said before when you sent this invididually:  I'd rather not move
> struct members to the common struture until we actually start using
> it there.  So for now please add it to the containing TCP-specific
> structure, although I'm looking forward to actually see code around
> it consolidated eventually.

FFFine....