netdev - RE: thunderx: nicvf_xdp_setup error code path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 21 Nov 2018 04:43:43 +0000
From:   "Goutham, Sunil" <Sunil.Goutham@...ium.com>
To:     Lorenzo Bianconi <lorenzo.bianconi@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: thunderx: nicvf_xdp_setup error code path



> -----Original Message-----
> From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
> Sent: 20 November 2018 23:27
> To: netdev@...r.kernel.org
> Cc: Goutham, Sunil <Sunil.Goutham@...ium.com>
> Subject: net: thunderx: nicvf_xdp_setup error code path
> 
> External Email
> 
> Hi all,
> 
> looking at thunderx XDP support I noticed that nic->xdp_prog pointer in
> nicvf_xdp_setup is not actually set to NULL if bpf_prog_add fails but it
> is initialized with bpf_prog_add error code. xdp_prog pointer value is used in
> the driver to verify if XDP is currently enabled.
> Moreover nicvf_xdp_setup does not report to the userspace any error code in
> case of failure.
> I wrote the following patch to fix the reported issues. Please note I just
> compiled it, not actually tested since I have no thunderx nic at the moment.
> 
> @Sunil: could you please give it a whirl? If it is ok I will post a formal
> patch, thanks
> 
> Regards,
> Lorenzo
> 

Thanks for fixing, changes look good to me, 

Sunil.