netdev - Re: [PATCH] net: faraday: ftmac100: remove netif_running(netdev) check before disabling interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20181121004903.GA28845@andestech.com>
Date:   Wed, 21 Nov 2018 08:49:03 +0800
From:   Vincent Chen <vincentc@...estech.com>
To:     David Miller <davem@...emloft.net>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "yuehaibing@...wei.com" <yuehaibing@...wei.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: faraday: ftmac100: remove netif_running(netdev)
 check before disabling interrupts

On Wed, Nov 21, 2018 at 02:28:43AM +0800, David Miller wrote:
> aFrom: Vincent Chen <vincentc@...estech.com>
> Date: Tue, 20 Nov 2018 13:37:46 +0800
> 
> > +	/* Disable interrupts for polling */
> > +	ftmac100_disable_all_int(priv);
> >  	if (likely(netif_running(netdev))) {
> > -		/* Disable interrupts for polling */
> > -		ftmac100_disable_all_int(priv);
> >  		napi_schedule(&priv->napi);
> >  	}
> 
> This is now a single-line basic block, so please remove the curly
> braces.
> 
> Thank you.

OK. I will remove it.
Thank you.