netdev - RE: [PATCH net-next v2 1/4] enetc: Introduce basic PF and VF ENETC ethernet drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <VI1PR04MB48803D4A3D8D331046CFC63196DB0@VI1PR04MB4880.eurprd04.prod.outlook.com>
Date:   Thu, 22 Nov 2018 13:06:01 +0000
From:   Claudiu Manoil <claudiu.manoil@....com>
To:     David Miller <davem@...emloft.net>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Alexandru Marginean <alexandru.marginean@....com>,
        Catalin Horghidan <catalin.horghidan@....com>
Subject: RE: [PATCH net-next v2 1/4] enetc: Introduce basic PF and VF ENETC
 ethernet drivers

>-----Original Message-----
>From: David Miller <davem@...emloft.net>
>Sent: Thursday, November 22, 2018 2:21 AM
>To: Claudiu Manoil <claudiu.manoil@....com>
>Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Alexandru
>Marginean <alexandru.marginean@....com>; Catalin Horghidan
><catalin.horghidan@....com>
>Subject: Re: [PATCH net-next v2 1/4] enetc: Introduce basic PF and VF ENETC
>ethernet drivers
>
>From: Claudiu Manoil <claudiu.manoil@....com>
>Date: Tue, 20 Nov 2018 20:15:31 +0200
>
>> diff --git a/drivers/net/ethernet/freescale/Makefile
>b/drivers/net/ethernet/freescale/Makefile
>> index 3b4ff08..20e5c2f9 100644
>> --- a/drivers/net/ethernet/freescale/Makefile
>> +++ b/drivers/net/ethernet/freescale/Makefile
>> @@ -23,3 +23,4 @@ obj-$(CONFIG_FSL_FMAN) += fman/
>>  obj-$(CONFIG_FSL_DPAA_ETH) += dpaa/
>>
>>  obj-$(CONFIG_FSL_DPAA2_ETH) += dpaa2/
>> +obj-$(CONFIG_NET_VENDOR_FREESCALE) += enetc/
>
>The driver enable Kconfig option should guard traversing into the
>driver subdirectory, not the vendor enable Kconfig knob.

The enetc/ dir contains 2 drivers, that share a lot of common code.
Would you agree if I change the vendor enable with the two configs
(one for each driver) as below?

-obj-$(CONFIG_NET_VENDOR_FREESCALE) += enetc/
+obj-$(CONFIG_FSL_ENETC) += enetc/
+obj-$(CONFIG_FSL_ENETC_VF) += enetc/

Thanks,
Claudiu