netdev - Re: [PATCH net] net: thunderx: set xdp_prog to NULL if bpf_prog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181122.114109.76000898595879800.davem@davemloft.net>
Date:   Thu, 22 Nov 2018 11:41:09 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     lorenzo.bianconi@...hat.com
Cc:     netdev@...r.kernel.org, Sunil.Goutham@...ium.com
Subject: Re: [PATCH net] net: thunderx: set xdp_prog to NULL if
 bpf_prog_add fails

From: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>
Date: Wed, 21 Nov 2018 16:32:10 +0100

> Set xdp_prog pointer to NULL if bpf_prog_add fails since that routine
> reports the error code instead of NULL in case of failure and xdp_prog
> pointer value is used in the driver to verify if XDP is currently
> enabled.
> Moreover report the error code to userspace if nicvf_xdp_setup fails
> 
> Fixes: 05c773f52b96 ("net: thunderx: Add basic XDP support")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@...hat.com>

Applied and queued up for -stable.