netdev - RE: [PATCH] can: flexcan: Implement CAN Runtime PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 22 Nov 2018 01:39:20 +0000
From:   Joakim Zhang <qiangqing.zhang@....com>
To:     Marc Kleine-Budde <mkl@...gutronix.de>,
        "wg@...ndegger.com" <wg@...ndegger.com>,
        "davem@...emloft.net" <davem@...emloft.net>
CC:     "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        Aisheng DONG <aisheng.dong@....com>
Subject: RE: [PATCH] can: flexcan: Implement CAN Runtime PM

Hi Marc,

Best Regards,
Joakim Zhang

> -----Original Message-----
> From: Marc Kleine-Budde <mkl@...gutronix.de>
> Sent: 2018年11月21日 22:36
> To: Joakim Zhang <qiangqing.zhang@....com>; wg@...ndegger.com;
> davem@...emloft.net
> Cc: linux-can@...r.kernel.org; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; dl-linux-imx <linux-imx@....com>; Aisheng
> DONG <aisheng.dong@....com>
> Subject: Re: [PATCH] can: flexcan: Implement CAN Runtime PM
> 
> On 10/19/18 11:45 AM, Joakim Zhang wrote:
> > From: Dong Aisheng <aisheng.dong@....com>
> >
> > Flexcan will be disabled during suspend if no wakeup function required
> > and enabled after resume accordingly. During this period, we could
> > explicitly disable clocks.
> >
> > Implement Runtime PM which will:
> > 1) Keep device in suspend state (clocks disabled) if it's not openned
> > 2) Make Power Domain framework be able to shutdown the corresponding
> > power domain of this device.
> 
> Without CONFIG_PM the device fails to probe:
> 
> > [  214.420606] flexcan 2090000.flexcan: 2090000.flexcan supply xceiver
> > not found, using dummy regulator [  214.445952] flexcan
> > 2090000.flexcan: Linked as a consumer to regulator.0 [  214.453448]
> > flexcan 2090000.flexcan: registering netdev failed [  214.459666]
> > flexcan 2090000.flexcan: Dropping the link to regulator.0 [
> > 214.472066] flexcan: probe of 2090000.flexcan failed with error -110

I will firstly send the patch to do FlexCAN wakeup upstream, you could review the patch "can: flexcan: add self wakeup support" when you are free.
After you have reviewed, then I will send patch to do FlexCAN runtime PM upstream. It will be convenient for you to review the patch.

Thanks a lot for your review.

Best Regards,
Joakim Zhang

> Marc
> 
> --
> Pengutronix e.K.                  | Marc Kleine-Budde           |
> Industrial Linux Solutions        | Phone: +49-231-2826-924     |
> Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
> Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |