netdev - Re: [PATCH net-next,v3 10/12] dsa: bcm_sf2: use flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bacb452a-6753-ba95-94e2-dca326164353@gmail.com>
Date:   Wed, 21 Nov 2018 20:56:08 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, thomas.lendacky@....com,
        ariel.elior@...ium.com, michael.chan@...adcom.com,
        santosh@...lsio.com, madalin.bucur@....com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jeffrey.t.kirsher@...el.com, tariqt@...lanox.com,
        saeedm@...lanox.com, jiri@...lanox.com, idosch@...lanox.com,
        jakub.kicinski@...ronome.com, peppe.cavallaro@...com,
        grygorii.strashko@...com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, alexandre.torgue@...com,
        joabreu@...opsys.com, linux-net-drivers@...arflare.com,
        ganeshgr@...lsio.com, ogerlitz@...lanox.com,
        Manish.Chopra@...ium.com
Subject: Re: [PATCH net-next,v3 10/12] dsa: bcm_sf2: use flow_rule
 infrastructure



On 11/20/2018 6:51 PM, Pablo Neira Ayuso wrote:
> Update this driver to use the flow_rule infrastructure, hence we can use
> the same code to populate hardware IR from ethtool_rx_flow and the
> cls_flower interfaces.
> 
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>
> ---

[snip]

> @@ -398,9 +411,10 @@ static int bcm_sf2_cfp_ipv4_rule_set(struct bcm_sf2_priv *priv, int port,
>  	 * Reserved		[1]
>  	 * UDF_Valid[8]		[0]
>  	 */
> -	core_writel(priv, v4_spec->tos << IPTOS_SHIFT |
> -		    ip_proto << IPPROTO_SHIFT | ip_frag << IP_FRAG_SHIFT |
> -		    udf_upper_bits(num_udf),
> +	core_writel(priv, ip.key->tos << IPTOS_SHIFT |
> +			  basic.key->n_proto << IPPROTO_SHIFT |
> +			  ip_frag << IP_FRAG_SHIFT |
> +			  udf_upper_bits(num_udf),

Can you maintain the alignment of the arguments here?

Every else looked okay, but I need to check the ipv6 structure to make
sure we can access it as 4x32 bits words like we did before.
-- 
Florian