netdev - Re: [PATCH net v3] net: phy: mscc: fix deadlock in vsc85xx_default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20181123.223510.1953898467509008988.davem@davemloft.net>
Date:   Fri, 23 Nov 2018 22:35:10 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     quentin.schulz@...tlin.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, allan.nielsen@...rochip.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        thomas.petazzoni@...tlin.com, alexandre.belloni@...tlin.com
Subject: Re: [PATCH net v3] net: phy: mscc: fix deadlock in
 vsc85xx_default_config

From: Quentin Schulz <quentin.schulz@...tlin.com>
Date: Fri, 23 Nov 2018 19:01:51 +0100

> The vsc85xx_default_config function called in the vsc85xx_config_init
> function which is used by VSC8530, VSC8531, VSC8540 and VSC8541 PHYs
> mistakenly calls phy_read and phy_write in-between phy_select_page and
> phy_restore_page.
> 
> phy_select_page and phy_restore_page actually take and release the MDIO
> bus lock and phy_write and phy_read take and release the lock to write
> or read to a PHY register.
> 
> Let's fix this deadlock by using phy_modify_paged which handles
> correctly a read followed by a write in a non-standard page.
> 
> Fixes: 6a0bfbbe20b0 ("net: phy: mscc: migrate to phy_select/restore_page functions")
> Signed-off-by: Quentin Schulz <quentin.schulz@...tlin.com>

Applied.