netdev - Re: consistency for statistics with XDP mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20181123.230736.1625945814784354695.davem@davemloft.net>
Date:   Fri, 23 Nov 2018 23:07:36 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     dsahern@...il.com
Cc:     toke@...e.dk, saeedm@...lanox.com, pstaszewski@...are.pl,
        netdev@...r.kernel.org, jasowang@...hat.com, brouer@...hat.com,
        mst@...hat.com
Subject: Re: consistency for statistics with XDP mode

From: David Ahern <dsahern@...il.com>
Date: Thu, 22 Nov 2018 09:51:27 -0700

> I would like to see basic packets, bytes, and dropped counters tracked
> for Rx and Tx via the standard netdev counters for all devices. This is
> for ease in accounting as well as speed and simplicity for bumping
> counters for virtual devices from bpf helpers.
> 
> From there, the XDP ones can be in the driver private stats as they are
> currently but with some consistency across drivers for redirects, drops,
> any thing else.

I would go so far as to say we should provide generic infrastructure
for this, in the format of a template of statistic name strings, a
templace structure to hold the counters, etc.